Messages in this thread | | | Date | Thu, 28 Jul 2022 17:50:00 +0800 | Subject | Re: [PATCH v2 4/4] dt-binding: perf: Add Amlogic DDR PMU | From | Jiucheng Xu <> |
| |
On 2022/7/27 15:09, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 27/07/2022 01:03, Jiucheng Xu wrote: >> Add binding documentation for the Amlogic G12 series DDR >> performance monitor unit. >> >> Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com> >> --- >> Changes v1 -> v2: >> - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml >> - Delete "model", "dmc_nr", "chann_nr" new properties >> - Fix compiling error >> --- >> .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 45 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > >> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >> new file mode 100644 >> index 000000000000..46ef52b61492 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic G12 DDR performance monitor >> + >> +maintainers: >> + - Jiucheng Xu <jiucheng.xu@amlogic.com> >> + >> +properties: >> + compatible: >> + oneOf: > That's not oneOf... > >> + - items: >> + - enum: >> + - amlogic,g12b-ddr-pmu >> + amlogic,g12a-ddr-pmu >> + amlogic,sm1-ddr-pmu >> + - const: amlogic,g12-ddr-pmu >> + >> + reg: >> + maxItems: 2 > You need to list and describe the items. > >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + ddr_pmu: ddr_pmu { >> + >> + #include <dt-bindings/interrupt-controller/arm-gic.h> > Code looks terrible... > >> + >> + compatible = "amlogic,g12a-ddr-pmu"; >> + reg = <0x0 0xff638000 0x0 0x100 >> + 0x0 0xff638c00 0x0 0x100>; > That's one item. You need to separate regs. > > > > Best regards, > Krzysztof Thanks for your comments. Once I thought the example DTB got generated means the yaml file is ok. I will learn the writing-schema. rst doc and modify the binding doc as your comments.
-- Thanks, Jiucheng
| |