Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 28 Jul 2022 23:04:24 +0200 | Subject | Re: [PATCH 1/2] drivers: serial: earlycon: Pass device-tree node |
| |
On Thu, Jul 28, 2022 at 4:41 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Thu, Jul 28, 2022 at 05:28:18PM +0300, Markuss Broks wrote: > > Pass a pointer to device-tree node in case the driver probed from > > OF. This makes early console drivers able to fetch options from > > device-tree node properties.
...
> > + unsigned long node; > > That should not be an unsigned long, but rather an 'int'. Something got > messed up, of_setup_earlycon() should be changed to reflect this before > propagating the error to other places in the kernel.
It's a pointer, but what puzzles me, why it can't be declared as a such:
struct device_node *node;
?
> And it's not really a "node" but an "offset", right?
Seems no.
-- With Best Regards, Andy Shevchenko
| |