lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 024/105] pinctrl: ralink: Check for null return of devm_kcalloc
    Date
    From: William Dean <williamsukatube@gmail.com>

    [ Upstream commit c3b821e8e406d5650e587b7ac624ac24e9b780a8 ]

    Because of the possible failure of the allocation, data->domains might
    be NULL pointer and will cause the dereference of the NULL pointer
    later.
    Therefore, it might be better to check it and directly return -ENOMEM
    without releasing data manually if fails, because the comment of the
    devm_kmalloc() says "Memory allocated with this function is
    automatically freed on driver detach.".

    Fixes: a86854d0c599b ("treewide: devm_kzalloc() -> devm_kcalloc()")
    Reported-by: Hacash Robot <hacashRobot@santino.com>
    Signed-off-by: William Dean <williamsukatube@gmail.com>
    Link: https://lore.kernel.org/r/20220710154922.2610876-1-williamsukatube@163.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
    index 09b0b8a16e99..2e971cbe2d7a 100644
    --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
    +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
    @@ -267,6 +267,8 @@ static int rt2880_pinmux_pins(struct rt2880_priv *p)
    p->func[i]->pin_count,
    sizeof(int),
    GFP_KERNEL);
    + if (!p->func[i]->pins)
    + return -ENOMEM;
    for (j = 0; j < p->func[i]->pin_count; j++)
    p->func[i]->pins[j] = p->func[i]->pin_first + j;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-27 18:54    [W:4.050 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site