lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 003/105] mlxsw: spectrum_router: Fix IPv4 nexthop gateway indication
    Date
    From: Ido Schimmel <idosch@nvidia.com>

    commit e5ec6a2513383fe2ecc2ee3b5f51d97acbbcd4d8 upstream.

    mlxsw needs to distinguish nexthops with a gateway from connected
    nexthops in order to write the former to the adjacency table of the
    device. The check used to rely on the fact that nexthops with a gateway
    have a 'link' scope whereas connected nexthops have a 'host' scope. This
    is no longer correct after commit 747c14307214 ("ip: fix dflt addr
    selection for connected nexthop").

    Fix that by instead checking the address family of the gateway IP. This
    is a more direct way and also consistent with the IPv6 counterpart in
    mlxsw_sp_rt6_is_gateway().

    Cc: stable@vger.kernel.org
    Fixes: 747c14307214 ("ip: fix dflt addr selection for connected nexthop")
    Fixes: 597cfe4fc339 ("nexthop: Add support for IPv4 nexthops")
    Signed-off-by: Ido Schimmel <idosch@nvidia.com>
    Reviewed-by: Amit Cohen <amcohen@nvidia.com>
    Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
    Reviewed-by: David Ahern <dsahern@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
    +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
    @@ -4003,7 +4003,7 @@ static bool mlxsw_sp_fi_is_gateway(const
    {
    const struct fib_nh *nh = fib_info_nh(fi, 0);

    - return nh->fib_nh_scope == RT_SCOPE_LINK ||
    + return nh->fib_nh_gw_family ||
    mlxsw_sp_nexthop4_ipip_type(mlxsw_sp, nh, NULL);
    }


    \
     
     \ /
      Last update: 2022-07-27 18:50    [W:4.383 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site