lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] staging: vt6655: Rename byOrgValue to reg_value in a macro
From
On 7/27/22 08:47, Greg Kroah-Hartman wrote:
> On Wed, Jul 20, 2022 at 06:24:32PM +0200, Philipp Hortmann wrote:
>> Fix name of a variable in a macro that uses CamelCase which is not
>> accepted by checkpatch.pl
>
> Why rename something you are about to delete in a later patch?
>
> thanks,
>
> greg k-h

I need to rename this variable. Does it matter if I do it in first or
last patch? When doing it first I do not have to review so much
checkpatch warnings.

Or is it OK to convert the macro to a function and rename the variable
in one patch?

thanks,

Philipp

\
 
 \ /
  Last update: 2022-07-27 17:55    [W:0.151 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site