Messages in this thread Patch in this message | | | From | Li Qiong <> | Subject | [PATCH] tracing: Do PTR_ERR() after IS_ERR() | Date | Wed, 27 Jul 2022 23:35:19 +0800 |
| |
Check IS_ERR() firstly, then do PTR_ERR().
Signed-off-by: Li Qiong <liqiong@nfschina.com> --- kernel/trace/ring_buffer_benchmark.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/ring_buffer_benchmark.c b/kernel/trace/ring_buffer_benchmark.c index 78e576575b79..a8f6b0725c45 100644 --- a/kernel/trace/ring_buffer_benchmark.c +++ b/kernel/trace/ring_buffer_benchmark.c @@ -439,17 +439,19 @@ static int __init ring_buffer_benchmark_init(void) if (!disable_reader) { consumer = kthread_create(ring_buffer_consumer_thread, NULL, "rb_consumer"); - ret = PTR_ERR(consumer); - if (IS_ERR(consumer)) + if (IS_ERR(consumer)) { + ret = PTR_ERR(consumer); goto out_fail; + } } producer = kthread_run(ring_buffer_producer_thread, NULL, "rb_producer"); - ret = PTR_ERR(producer); - if (IS_ERR(producer)) + if (IS_ERR(producer)) { + ret = PTR_ERR(producer); goto out_kill; + } /* * Run them as low-prio background tasks by default: -- 2.11.0
| |