Messages in this thread | | | Date | Wed, 27 Jul 2022 17:58:02 +0300 | From | Vladimir Oltean <> | Subject | Re: [net-next: PATCH v2] net: dsa: mv88e6xxx: fix speed setting for CPU/DSA ports |
| |
On Wed, Jul 27, 2022 at 01:09:18AM +0200, Marcin Wojtas wrote: > Commit 3c783b83bd0f ("net: dsa: mv88e6xxx: get rid of SPEED_MAX setting") > stopped relying on SPEED_MAX constant and hardcoded speed settings > for the switch ports and rely on phylink configuration. > > It turned out, however, that when the relevant code is called, > the mac_capabilites of CPU/DSA port remain unset. > mv88e6xxx_setup_port() is called via mv88e6xxx_setup() in > dsa_tree_setup_switches(), which precedes setting the caps in > phylink_get_caps down in the chain of dsa_tree_setup_ports(). > > As a result the mac_capabilites are 0 and the default speed for CPU/DSA > port is 10M at the start. To fix that, execute mv88e6xxx_get_caps() > and obtain the capabilities driectly. > > Fixes: 3c783b83bd0f ("net: dsa: mv88e6xxx: get rid of SPEED_MAX setting") > Signed-off-by: Marcin Wojtas <mw@semihalf.com> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
| |