lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V7 01/16] rv: Add Runtime Verification (RV) interface
From
On 7/26/22 22:59, Steven Rostedt wrote:
>>>> +static void turn_monitoring_on(void)
>>>> +{
>>>> + reset_all_monitors();
>>> Why does this reset all monitors but turn_monitoring_off() does not?
>> When we turn monitoring off, the monitors will stop monitoring while yet
>> in sync with the events generated by the system, i.e., all the events after
>> the start were processed.
>>
>> But if we disabled the monitor, and some events get ignored, the monitors
>> will be out of sync with the system. Thus, resetting the monitor to
>> for a synchronization between the monitors and the system is needed, before
>> enabling monitoring back.
>>
>>> You should keep that out.
>> did not get :-(
> I don't like the way the _on() and _off() are different.
>
> Have the _on() just turn in on *without* the reset.
>
> If you need the reset, then make a separate function called:
>
> static void turn_monitoring_on_with_reset(void)
> {
> reset_all_monitors();
> turn_monitoring_on();
> }
>

as usual... https://www.youtube.com/watch?v=qYo0lVVH2wU

Fixed in v8, along with all other changes.

Thanks
-- Daniel

\
 
 \ /
  Last update: 2022-07-27 15:43    [W:0.060 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site