lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [net-next: PATCH v3 7/8] net: mdio: introduce fwnode_mdiobus_register_device()
    On Wed, Jul 27, 2022 at 08:43:20AM +0200, Marcin Wojtas wrote:
    > As a preparation patch to extend MDIO capabilities in the ACPI world,
    > introduce fwnode_mdiobus_register_device() to register non-PHY
    > devices on the mdiobus.

    ...

    > + dev_dbg(&mdio->dev, "registered mdio device %p fwnode at address %i\n",
    > + child, addr);

    "%p" makes a little sense (and we have hashed pointers). I think the "%pfw"
    would be much better for the user to see.

    ...

    > - dev_dbg(&mdio->dev, "registered mdio device %pOFn at address %i\n",
    > - child, addr);

    Exactly my point above.

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2022-07-27 15:34    [W:2.972 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site