Messages in this thread | | | Date | Wed, 27 Jul 2022 16:32:36 +0300 | From | Andy Shevchenko <> | Subject | Re: [net-next: PATCH v3 7/8] net: mdio: introduce fwnode_mdiobus_register_device() |
| |
On Wed, Jul 27, 2022 at 08:43:20AM +0200, Marcin Wojtas wrote: > As a preparation patch to extend MDIO capabilities in the ACPI world, > introduce fwnode_mdiobus_register_device() to register non-PHY > devices on the mdiobus.
...
> + dev_dbg(&mdio->dev, "registered mdio device %p fwnode at address %i\n", > + child, addr);
"%p" makes a little sense (and we have hashed pointers). I think the "%pfw" would be much better for the user to see.
...
> - dev_dbg(&mdio->dev, "registered mdio device %pOFn at address %i\n", > - child, addr);
Exactly my point above.
-- With Best Regards, Andy Shevchenko
| |