Messages in this thread | | | Date | Wed, 27 Jul 2022 13:54:09 +0200 | Subject | Re: [PATCH 1/9] trinity: Add base driver | From | Krzysztof Kozlowski <> |
| |
On 25/07/2022 08:53, Jiho Chu wrote: > It contains the base codes for trinity driver. Minimal codes to load and > probe device is provided. The Trinity Family is controlled by the > Memory-Mapped Registers, the register addresses and offsets are > described. And user api interfaces are presented to control device under > ioctl manner. >
> + dev = &pdev->dev; > + dev->id = ((desc->ver & TRINITY_MASK_DEV) >> TRINITY_SHIFT_DEV); > + > + /* set private data */ > + drv = devm_kzalloc(dev, sizeof(*drv), GFP_KERNEL); > + if (drv == NULL) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, drv); > + dev_set_drvdata(dev, drv); > + > + drv->dev = dev; > + drv->desc = desc; > + > + np = dev->of_node; > + if (of_property_match_string(np, "samsung,trinity-type", desc->type))
Let me be more specific.
You need to document your bindings.
Patch cannot be accepted without them.
Best regards, Krzysztof
| |