Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] watchdog: Fix build error when CONFIG_SOFTLOCKUP_DETECTOR is not set | Date | Wed, 27 Jul 2022 21:38:44 +1000 |
| |
Laurent Dufour <ldufour@linux.ibm.com> writes: > Sachin reported the following build error when CONFIG_SOFTLOCKUP_DETECTOR > is not set: > > kernel/watchdog.c:597:20: error: static declaration of 'lockup_detector_reconfigure' follows non-static declaration > static inline void lockup_detector_reconfigure(void) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from kernel/watchdog.c:17: > ./include/linux/nmi.h:125:6: note: previous declaration of 'lockup_detector_reconfigure' was here > void lockup_detector_reconfigure(void); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > The definition of lockup_detector_reconfigure should be exported even in > that case, and __lockup_detector_reconfigure should remain static. > > Fixes: 24a1260705b7 ("watchdog: export lockup_detector_reconfigure") > Reported-by: Sachin Sant <sachinp@linux.ibm.com> > Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com> > --- > kernel/watchdog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks.
I'll squash that in to the original commit.
cheers
| |