Messages in this thread | | | From | Balsam CHIHI <> | Date | Wed, 27 Jul 2022 11:02:51 +0200 | Subject | Re: [PATCH v8 2/6] dt-bindings: thermal: Add binding document for LVTS thermal controllers |
| |
On Wed, Jul 27, 2022 at 10:17 AM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 26/07/22 15:55, Balsam CHIHI ha scritto: > > This patch adds dt-binding documents for mt8192 and mt8195 thermal controllers. > > > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > > --- > > .../thermal/mediatek,mt8192-lvts.yaml | 73 ++++++++++++++++++ > > .../thermal/mediatek,mt8195-lvts.yaml | 75 +++++++++++++++++++ > > 2 files changed, 148 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,mt8192-lvts.yaml > > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,mt8195-lvts.yaml > > > > Hello Balsam, > > I don't think that having two separated files is necessary (and I don't know if > that's correct, even). > > You're referring to variants of the same hardware (and using the same driver, but > that's not really relevant here), so my suggestion here is to have only one YAML, > named like "mediatek,lvts-thermal.yaml", where we list all of the compatibles for > both MT8192 and MT8195 (and future SoCs). > > Regards, > Angelo Hello AngeloGioacchino,
Thank you for the feedback. Well received. I will resend ASAP.
Best regards, Balsam.
| |