Messages in this thread | | | Date | Thu, 28 Jul 2022 01:04:14 +0300 | Subject | Re: Aw: [RFC PATCH net-next] dt-bindings: net: dsa: mediatek,mt7530: completely rework binding | From | Arınç ÜNAL <> |
| |
On 28.07.2022 00:46, Arınç ÜNAL wrote: > On 28.07.2022 00:26, Frank Wunderlich wrote: >> Am 27. Juli 2022 22:59:16 MESZ schrieb "Arınç ÜNAL" >> <arinc.unal@arinc9.com>: >>> On 27.07.2022 23:31, Frank Wunderlich wrote: >>>> >> >>> I've seen this under mt7530_setup(): >>> The bit for MHWTRAP_P6_DIS is cleared to enable port 6 with the >>> comment "Enable Port 6 only; P5 as GMAC5 which currently is not >>> supported". >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/drivers/net/dsa/mt7530.c#n2189 >>> >> >> Later in same function it looks comment is obsolete. >> >> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/drivers/net/dsa/mt7530.c#n2234
By the way, port 6 seems to be enabled even though port 5 is used as the cpu port. Shouldn’t that be behind a check?
>> >> >> I know that rene added p5 support while phylink conversion,but not >> sure it was complete. > > Thanks for pointing it out. I suppose it works fine since you tested it. > I will update my patch to allow setting port 5 as cpu port along with > splitting the patch. > > Arınç
| |