Messages in this thread | | | Date | Wed, 27 Jul 2022 12:44:01 -0700 | Subject | Re: [PATCH v4 5/7] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() | From | Bart Van Assche <> |
| |
On 7/27/22 00:10, Jinyoung CHOI wrote: > diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h > index 94bcfec98fb8..78adc556444a 100644 > --- a/include/ufs/ufshcd.h > +++ b/include/ufs/ufshcd.h > @@ -1017,6 +1017,12 @@ static inline bool ufshcd_is_wb_allowed(struct ufs_hba *hba) > return hba->caps & UFSHCD_CAP_WB_EN; > } > > +static inline bool ufshcd_is_wb_buf_flush_allowed(struct ufs_hba *hba) > +{ > + return ufshcd_is_wb_allowed(hba) && > + !(hba->quirks & UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL); > +}
Since this function is only used inside the UFS driver core it should be added in drivers/ufs/core/ufshcd-priv.h instead of include/ufs/ufshcd.h.
Thanks,
Bart.
| |