lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH v2] page_alloc: fix invalid watemark check on a negative value
From
Date


>--------- Original Message ---------
>Sender : Andrew Morton <akpm@linux-foundation.org>
>Date : 2022-07-26 03:37 (GMT+9)
>Title : Re: [PATCH v2] page_alloc: fix invalid watemark check on a negative value

>On Mon, 25 Jul 2022 18:52:12 +0900 Jaewon Kim <jaewon31.kim@samsung.com> wrote:
>
>> There was a report that a task is waiting at the
>> throttle_direct_reclaim. The pgscan_direct_throttle in vmstat was
>> increasing.
>> 
>> This is a bug where zone_watermark_fast returns true even when the free
>> is very low. The commit f27ce0e14088 ("page_alloc: consider highatomic
>> reserve in watermark fast") changed the watermark fast to consider
>> highatomic reserve. But it did not handle a negative value case which
>> can be happened when reserved_highatomic pageblock is bigger than the
>> actual free.
>> 
>> If watermark is considered as ok for the negative value, allocating
>> contexts for order-0 will consume all free pages without direct reclaim,
>> and finally free page may become depleted except highatomic free.
>> 
>> Then allocating contexts may fall into throttle_direct_reclaim. This
>> symptom may easily happen in a system where wmark min is low and other
>> reclaimers like kswapd does not make free pages quickly.
>> 
>> Handle the negative case by using MIN.
>> 
>
>Thanks, I added cc:stable to this.
>

Sorry for your inconvenience.

Could you fix a typo by adding r to watermark on title

- page_alloc: fix invalid watemark check on a negative value
+ page_alloc: fix invalid watermark check on a negative value


I've appreciated it in advance.

\
 
 \ /
  Last update: 2022-07-27 09:47    [W:0.059 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site