Messages in this thread | | | Date | Wed, 27 Jul 2022 19:33:13 +0200 | From | Max Staudt <> | Subject | Re: [RFC PATCH v3 8/9] can: slcan: add support to set bit time register (btr) |
| |
On Wed, 27 Jul 2022 19:28:45 +0200 Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> On Wed, Jul 27, 2022 at 7:21 PM Marc Kleine-Budde <mkl@pengutronix.de> wrote: > > > > Ok - We avoided writing bit timing registers from user space into the > > hardware for all existing drivers. If there isn't a specific use case, > > let's skip this patch. If someone comes up with a use case we can think > > of a proper solution. > > Ok. So do I also remove the 7/9 "ethtool: add support to get/set CAN > bit time register" > patch ?
If I may answer as well - IMHO, yes.
Unless we know that BTR is something other than just a different way to express the bitrate, I'd skip it, yes. Because bitrate is already handled by other, cross-device mechanisms.
Max
| |