lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 124/158] tcp: Fix a data-race around sysctl_tcp_rfc1337.
    Date
    From: Kuniyuki Iwashima <kuniyu@amazon.com>

    [ Upstream commit 0b484c91911e758e53656d570de58c2ed81ec6f2 ]

    While reading sysctl_tcp_rfc1337, it can be changed concurrently.
    Thus, we need to add READ_ONCE() to its reader.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/ipv4/tcp_minisocks.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
    index 6854bb1fb32b..700ea548d125 100644
    --- a/net/ipv4/tcp_minisocks.c
    +++ b/net/ipv4/tcp_minisocks.c
    @@ -173,7 +173,7 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,
    * Oh well... nobody has a sufficient solution to this
    * protocol bug yet.
    */
    - if (twsk_net(tw)->ipv4.sysctl_tcp_rfc1337 == 0) {
    + if (!READ_ONCE(twsk_net(tw)->ipv4.sysctl_tcp_rfc1337)) {
    kill:
    inet_twsk_deschedule_put(tw);
    return TCP_TW_SUCCESS;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-27 19:43    [W:2.131 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site