lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 051/158] net: dsa: microchip: ksz_common: Fix refcount leak bug
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit a14bd7475452c51835dd5a0cee4c8fa48dd0b539 ]

    In ksz_switch_register(), we should call of_node_put() for the
    reference returned by of_get_child_by_name() which has increased
    the refcount.

    Fixes: 912aae27c6af ("net: dsa: microchip: really look for phy-mode in port nodes")
    Signed-off-by: Liang He <windhl@126.com>
    Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
    Link: https://lore.kernel.org/r/20220714153138.375919-1-windhl@126.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/dsa/microchip/ksz_common.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
    index 8014b18d9391..aa0bcf01e20a 100644
    --- a/drivers/net/dsa/microchip/ksz_common.c
    +++ b/drivers/net/dsa/microchip/ksz_common.c
    @@ -447,18 +447,21 @@ int ksz_switch_register(struct ksz_device *dev,
    ports = of_get_child_by_name(dev->dev->of_node, "ethernet-ports");
    if (!ports)
    ports = of_get_child_by_name(dev->dev->of_node, "ports");
    - if (ports)
    + if (ports) {
    for_each_available_child_of_node(ports, port) {
    if (of_property_read_u32(port, "reg",
    &port_num))
    continue;
    if (!(dev->port_mask & BIT(port_num))) {
    of_node_put(port);
    + of_node_put(ports);
    return -EINVAL;
    }
    of_get_phy_mode(port,
    &dev->ports[port_num].interface);
    }
    + of_node_put(ports);
    + }
    dev->synclko_125 = of_property_read_bool(dev->dev->of_node,
    "microchip,synclko-125");
    dev->synclko_disable = of_property_read_bool(dev->dev->of_node,
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-27 19:36    [W:4.055 / U:2.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site