lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 028/158] pinctrl: sunplus: Add check for kcalloc
    Date
    From: William Dean <williamsukatube@gmail.com>

    [ Upstream commit acf50233fc979b566e3b87d329191dcd01e2a72c ]

    As the potential failure of the kcalloc(),
    it should be better to check it in order to
    avoid the dereference of the NULL pointer.

    Fixes: aa74c44be19c8 ("pinctrl: Add driver for Sunplus SP7021")
    Reported-by: Hacash Robot <hacashRobot@santino.com>
    Signed-off-by: William Dean <williamsukatube@gmail.com>
    Link: https://lore.kernel.org/r/20220710154822.2610801-1-williamsukatube@163.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/sunplus/sppctl.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/pinctrl/sunplus/sppctl.c b/drivers/pinctrl/sunplus/sppctl.c
    index 3ba47040ac42..2b3335ab56c6 100644
    --- a/drivers/pinctrl/sunplus/sppctl.c
    +++ b/drivers/pinctrl/sunplus/sppctl.c
    @@ -871,6 +871,9 @@ static int sppctl_dt_node_to_map(struct pinctrl_dev *pctldev, struct device_node
    }

    *map = kcalloc(*num_maps + nmG, sizeof(**map), GFP_KERNEL);
    + if (*map == NULL)
    + return -ENOMEM;
    +
    for (i = 0; i < (*num_maps); i++) {
    dt_pin = be32_to_cpu(list[i]);
    pin_num = FIELD_GET(GENMASK(31, 24), dt_pin);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-27 19:32    [W:5.385 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site