lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 030/201] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 80192eff64eee9b3bc0594a47381937b94b9d65a ]

    of_find_matching_node_and_match() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/power/reset/arm-versatile-reboot.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/power/reset/arm-versatile-reboot.c b/drivers/power/reset/arm-versatile-reboot.c
    index 08d0a07b58ef..c7624d7611a7 100644
    --- a/drivers/power/reset/arm-versatile-reboot.c
    +++ b/drivers/power/reset/arm-versatile-reboot.c
    @@ -146,6 +146,7 @@ static int __init versatile_reboot_probe(void)
    versatile_reboot_type = (enum versatile_reboot)reboot_id->data;

    syscon_regmap = syscon_node_to_regmap(np);
    + of_node_put(np);
    if (IS_ERR(syscon_regmap))
    return PTR_ERR(syscon_regmap);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-27 19:02    [W:4.058 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site