Messages in this thread | | | From | Prashant Malani <> | Date | Tue, 26 Jul 2022 09:50:24 -0700 | Subject | Re: [PATCH] usb: typec: retimer: Add missing id check in match callback |
| |
HI Nícolas,
On Mon, Jul 25, 2022 at 1:31 PM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > The fwnode_connection_find_match() function handles two cases: named > references and graph endpoints. In the second case, the match function > passed in is called with the id to check for the match. However, the > match function for the recently added type-c retimer class assumes the > connection has already been matched (which is only true for the first > case). > > The result is that with that change, all type-c nodes with graph > endpoints defer probe indefinitely, independently of having a retimer > connection or not. > > Add the missing check, like is done by the type-c mux and usb role > switch code, to fix the issue. > > Fixes: ddaf8d96f93b ("usb: typec: Add support for retimers") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> FWIW, Reviewed-by: Prashant Malani <pmalani@chromium.org>
| |