| Date | Tue, 26 Jul 2022 12:26:29 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH V7 02/16] rv: Add runtime reactors interface |
| |
On Mon, 25 Jul 2022 22:11:14 +0200 Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
> +/** > + * reactor_cleanup_monitor - cleanup a monitor reference > + * @mdef: monitor's definition. > + */ > +void reactor_cleanup_monitor(struct rv_monitor_def *mdef) > +{ > + mdef->rdef->counter--; > +} > +
Doesn't this require a lock? Also you might want to add a WARN_ONCE() if it goes below zero.
-- Steve
|