Messages in this thread | | | Date | Tue, 26 Jul 2022 15:29:17 +0200 | Subject | Re: [PATCH 03/10] soc: qcom: icc-bwmon: drop unused BWMON_ZONE_COUNT | From | Krzysztof Kozlowski <> |
| |
On 26/07/2022 13:25, Sibi Sankar wrote: > Hey Krzysztof, > > Thanks for working on the llcc bwmon patch series! > > > On 7/21/22 12:58 AM, Krzysztof Kozlowski wrote: >> BWMON_ZONE_COUNT define is not used. >> >> Cc: Rajendra Nayak <quic_rjendra@quicinc.com> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> drivers/soc/qcom/icc-bwmon.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c >> index 3415f42523cd..b76a59d9002c 100644 >> --- a/drivers/soc/qcom/icc-bwmon.c >> +++ b/drivers/soc/qcom/icc-bwmon.c >> @@ -105,7 +105,6 @@ >> >> /* BWMONv4 count registers use count unit of 64 kB */ >> #define BWMON_COUNT_UNIT_KB 64 >> -#define BWMON_ZONE_COUNT 0x2d8 > > Apart from ^^ a few more defines like BWMON_GLOBAL_IRQ_STATUS,
I will remove it in v2.
> THRESHOLD_COUNT_ZONE2_SHIFT were unused as well.
This one was used in the code and later replaced by reg_field shifts.
> > Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
Thanks!
Best regards, Krzysztof
| |