lkml.org 
[lkml]   [2022]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/5] ARM: stacktrace: Avoid duplicate saving of exception PC value
From
Date


On 2022/7/26 18:22, Russell King (Oracle) wrote:
> On Tue, Jul 12, 2022 at 10:15:24AM +0800, Li Huafei wrote:
>> @@ -34,6 +37,9 @@ void arm_get_current_stackframe(struct pt_regs *regs, struct stackframe *frame)
>> frame->kr_cur = NULL;
>> frame->tsk = current;
>> #endif
>> +#ifdef CONFIG_UNWINDER_FRAME_POINTER
>> + frame->ex_frame = in_entry_text(frame->pc) ? true : false;
>
> in_entry_text() returns a bool, so there's no need for the ternary
> operator. The same comment applies throughout this patch.
>
OK, I will fix it in v3.

Thanks,
Huafei

\
 
 \ /
  Last update: 2022-07-26 14:22    [W:0.087 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site