Messages in this thread | | | From | Dmitry Rokosov <> | Subject | Re: [PATCH v1 1/3] units: complement the set of Hz units | Date | Tue, 26 Jul 2022 09:49:15 +0000 |
| |
Hello Andy,
Thank you for quick review.
On Mon, Jul 25, 2022 at 11:29:31PM +0200, Andy Shevchenko wrote: > On Mon, Jul 25, 2022 at 8:44 PM Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote: > > > > Currently, Hz units do not have milli, micro and nano Hz coefficients. > > Some drivers (IIO especially) use their analogues to calculate > > appropriate Hz values. This patch includes them to units.h definitions, > > so they can be used from different kernel places. > > ... > > > +#define NHZ_PER_HZ 1000000000UL > > +#define UHZ_PER_HZ 1000000UL > > +#define MHZ_PER_HZ 1000UL > > mHZ perhaps? >
I'm afraid it will not have the same view as other HZ units. Maybe it's better to call mHZ as MILLIHZ? What do you think?
-- Thank you, Dmitry
| |