lkml.org 
[lkml]   [2022]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] parisc: check the return value of ioremap() in lba_driver_probe()
From
On 7/22/22 04:57, williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@gmail.com>
>
> The function ioremap() in lba_driver_probe() can fail, so
> its return value should be checked.
>
> Fixes: 4bdc0d676a643 ("remove ioremap_nocache and devm_ioremap_nocache")
> Reported-by: Hacash Robot <hacashRobot@santino.com>
> Signed-off-by: William Dean <williamsukatube@gmail.com>

applied.

Thanks!
Helge

> ---
> drivers/parisc/lba_pci.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
> index 732b516c7bf8..afc6e66ddc31 100644
> --- a/drivers/parisc/lba_pci.c
> +++ b/drivers/parisc/lba_pci.c
> @@ -1476,9 +1476,13 @@ lba_driver_probe(struct parisc_device *dev)
> u32 func_class;
> void *tmp_obj;
> char *version;
> - void __iomem *addr = ioremap(dev->hpa.start, 4096);
> + void __iomem *addr;
> int max;
>
> + addr = ioremap(dev->hpa.start, 4096);
> + if (addr == NULL)
> + return -ENOMEM;
> +
> /* Read HW Rev First */
> func_class = READ_REG32(addr + LBA_FCLASS);
>

\
 
 \ /
  Last update: 2022-07-26 10:29    [W:0.042 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site