Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 26 Jul 2022 10:02:22 +0200 | Subject | Re: [PATCH 2/2] pinctrl: amd: Use unicode for debugfs output |
| |
On Sat, Jul 23, 2022 at 12:08 AM Mario Limonciello <mario.limonciello@amd.com> wrote:
> The output is currently split across two lines making it more > difficult to parse unless the newlines are removed between pins > or it's read in by a parser like Libreoffice Calc or Google docs. > > To make it easier to follow to the naked eye in a terminal window: > * drop the newline in the middle of pin definitions > * shorten all output using unicode characters > * align all pipe delimitters > * output the same phrase even for disabled functions > (but with a ∅ character) > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
That's a bit unorthodox, what happens when someone uses their old VT100 terminal to look at this file?
BIUT! It is a debugfs file, and you folks at AMD are going to be using this and I just assume that you folks have aligned internally that this is how you want things so I just applied this.
We need testing in linux-next for this anyway, the merge window is close. If the other AMD people don't like it for some reason I can always pull it out.
Yours, Linus Walleij
| |