lkml.org 
[lkml]   [2022]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC v3 06/17] perf kwork: Implement perf kwork report
From
Date
Hello,

On 2022/7/27 1:40, Arnaldo Carvalho de Melo wrote:
> Em Sat, Jul 09, 2022 at 09:50:22AM +0800, Yang Jihong escreveu:
>> +
>> +static void report_print_work(struct perf_kwork *kwork,
>> + struct kwork_work *work)
>> +{
>> + int ret = 0;
>> + char kwork_name[PRINT_KWORK_NAME_WIDTH];
>> + char max_runtime_start[32], max_runtime_end[32];
>
> Committer notes:
>
> - Add some {} for multiline for/if blocks
>
> - Return the calculated number of printed bytes in report_print_work,
> otherwise soem compilers will complain that variable isn't used, e.g.:
>
> 2 92.64 almalinux:9 : FAIL clang version 13.0.1 (Red Hat 13.0.1-1.el9)
> builtin-kwork.c:1061:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
> int ret = 0;
>
>
OK, I'll fix it in next version.

Regards,
Jihong

\
 
 \ /
  Last update: 2022-07-27 02:40    [W:0.090 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site