Messages in this thread | | | Subject | Re: [PATCH] ASoC: amd: acp: Fix initialization of ext_intr_stat1 in i2s_irq_handler() | From | Tom Rix <> | Date | Mon, 25 Jul 2022 13:30:27 -0700 |
| |
On 7/25/22 11:05 AM, Nathan Chancellor wrote: > Clang warns: > > ../sound/soc/amd/acp/acp-platform.c:117:19: error: variable 'ext_intr_stat1' is uninitialized when used here [-Werror,-Wuninitialized] > if (stream && (ext_intr_stat1 & stream->irq_bit)) { > ^~~~~~~~~~~~~~ > ../sound/soc/amd/acp/acp-platform.c:97:35: note: initialize the variable 'ext_intr_stat1' to silence this warning > u32 ext_intr_stat, ext_intr_stat1, i; > ^ > = 0 > 1 error generated. > > The variable was not properly renamed, correct it to resolve the > warning. > > Fixes: 93f53881473c ("ASoC: amd: acp: Modify local variables name to generic") > Link: https://github.com/ClangBuiltLinux/linux/issues/1675 > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Tom Rix <trix@redhat.com> > --- > sound/soc/amd/acp/acp-platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c > index 10730d33c3b0..f561d39b33e2 100644 > --- a/sound/soc/amd/acp/acp-platform.c > +++ b/sound/soc/amd/acp/acp-platform.c > @@ -100,7 +100,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data) > return IRQ_NONE; > > if (adata->rsrc->no_of_ctrls == 2) > - ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1))); > + ext_intr_stat1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1))); > > ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used)); > > > base-commit: be0aa8d4b0fcb4532bf7973141e911998ab39508
| |