Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 25 Jul 2022 22:04:47 +0200 | Subject | Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow |
| |
On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli > <srinivas.neeli@xilinx.com> wrote: > > > > Current implementation is not able to configure more than 32 pins > > due to incorrect data type. So type casting with unsigned long > > to avoid it.
> > Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs")
It doesn't fix anything, I already reject one such "fix" during development of this patch. Thanks!
...
> > @@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v) > > const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5); > > > > map[index] &= ~(0xFFFFFFFFul << offset); > > - map[index] |= v << offset; > > + map[index] |= (unsigned long)v << offset; > > }
> Applied, thanks!
False positive.
-- With Best Regards, Andy Shevchenko
| |