Messages in this thread Patch in this message | | | From | Dario Binacchi <> | Subject | [PATCH v2 4/6] can: slcan: use the generic can_change_mtu() | Date | Mon, 25 Jul 2022 08:54:17 +0200 |
| |
It is useless to define a custom function that does nothing but always return the same error code. Better to use the generic can_change_mtu() function.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> ---
(no changes since v1)
drivers/net/can/slcan/slcan-core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 09d4abbbd9f4..919311890d2c 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -740,16 +740,11 @@ static int slcan_netdev_open(struct net_device *dev) return err; } -static int slcan_netdev_change_mtu(struct net_device *dev, int new_mtu) -{ - return -EINVAL; -} - static const struct net_device_ops slcan_netdev_ops = { .ndo_open = slcan_netdev_open, .ndo_stop = slcan_netdev_close, .ndo_start_xmit = slcan_netdev_xmit, - .ndo_change_mtu = slcan_netdev_change_mtu, + .ndo_change_mtu = can_change_mtu, }; /****************************************** -- 2.32.0
| |