Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING sections | Date | Mon, 25 Jul 2022 16:07:47 +0100 |
| |
On 25/07/22 10:59, Vincent Donnefort wrote: > The DYING/STARTING callbacks are not expected to fail. However, as reported > by Derek, drivers such as tboot are still free to return errors within > those sections, which halts the hot(un)plug and leaves the CPU in an > unrecoverable state. > > No rollback being possible there, let's only log the failures and proceed > with the following steps. This restores the hotplug behaviour prior to > commit 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()") > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215867 > Fixes: 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()") > Reported-by: Derek Dolney <z23@posteo.net> > Signed-off-by: Vincent Donnefort <vdonnefort@google.com> > Tested-by: Derek Dolney <z23@posteo.net> >
The changelog has some undesired stowaways below, but regardless: Reviewed-by: Valentin Schneider <vschneid@redhat.com>
> v4 -> v5: > - Remove WARN, only log broken states with pr_warn. > v3 -> v4: > - Sorry ... wrong commit description style ... > v2 -> v3: > - Tested-by tag. > - Refine commit description. > - Bugzilla link. > v1 -> v2: > - Commit message rewording. > - More details in the warnings. > - Some variable renaming >
| |