lkml.org 
[lkml]   [2022]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image processing accelerator
    On Fri, Jul 22, 2022 at 05:28:56PM +0900, Yuji Ishikawa wrote:
    > Add support to DNN image processing accelerator on Toshiba Visconti ARM SoCs.
    > The accelerator is applicable to DNN inference tasks.
    >
    > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
    > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
    > ---
    > v1 -> v2:
    > - applied checkpatch.pl --strict
    > - removed unused code
    > ---
    > drivers/soc/visconti/Kconfig | 6 +
    > drivers/soc/visconti/Makefile | 2 +
    > drivers/soc/visconti/dnn/Makefile | 6 +
    > drivers/soc/visconti/dnn/dnn.c | 523 +++++++++++++++++++++++++
    > drivers/soc/visconti/dnn/hwd_dnn.c | 183 +++++++++
    > drivers/soc/visconti/dnn/hwd_dnn.h | 68 ++++
    > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 +++++++++++
    > drivers/soc/visconti/uapi/dnn.h | 77 ++++
    > 8 files changed, 1093 insertions(+)
    > create mode 100644 drivers/soc/visconti/dnn/Makefile
    > create mode 100644 drivers/soc/visconti/dnn/dnn.c
    > create mode 100644 drivers/soc/visconti/dnn/hwd_dnn.c
    > create mode 100644 drivers/soc/visconti/dnn/hwd_dnn.h
    > create mode 100644 drivers/soc/visconti/dnn/hwd_dnn_reg.h
    > create mode 100644 drivers/soc/visconti/uapi/dnn.h
    >
    > diff --git a/drivers/soc/visconti/Kconfig b/drivers/soc/visconti/Kconfig
    > index 8b1378917..a25287d0c 100644
    > --- a/drivers/soc/visconti/Kconfig
    > +++ b/drivers/soc/visconti/Kconfig
    > @@ -1 +1,7 @@
    > +if ARCH_VISCONTI
    > +
    > +config VISCONTI_DNN
    > + bool "Visconti DNN driver"
    > +

    We can't take Kconfig options with no help text at all, please provide
    the needed information here.

    And why can't this be a module?

    \
     
     \ /
      Last update: 2022-07-25 14:49    [W:5.139 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site