Messages in this thread | | | Date | Mon, 25 Jul 2022 12:57:30 +0100 | From | John Garry <> | Subject | Re: [PATCH 0/2] arm64 defconfig: Get faddr2line working |
| |
On 24/07/2022 21:35, Arnd Bergmann wrote:
Here's a brief'ish summary for why it's ok to delete these mentioned configs:
> CONFIG_ARCH_BCMBCA=y
On next-20220722, config ARCH_BCMBCA is selected by config ARCH_BCM4908 from arch/arm64/Kconfig.platforms and the latter is enabled in the defconfig, so no need to explicitly enable in the defconfig.
On arm-soc arm/defconfig, config ARCH_BCMBCA does not exist for arm64 platforms yet, so this is why we see this config deleted for the sync. > CONFIG_SECCOMP=y
Since commit 282a181b1a0d, config SECCOMP was changed to def_bool y, so no need to explicitly enable in the defconfig.
> CONFIG_QRTR=m
From commit fdf4632aa834, we enable config ATH11K_PCI, which selects config QRTR, so no need to explicitly enable in the defconfig.
> CONFIG_PINCTRL_MSM=y
From commit c807a335d3b1, config PINCTRL_SM8450 is enabled, which selects PINCTRL_MSM, so no need to explicitly enable in the defconfig.
> CONFIG_SND_SOC_TEGRA210_OPE=m
There is no issue on next-20220722.
On arm-soc arm/defconfig, config SND_SOC_TEGRA210_OPE just does not yet exist, so that's why it get removed from the sync of the defconfig.
> CONFIG_MAILBOX=y
In commit fc739069aa92, config MAILBOX was enabled in the defconfig but it was already being enabled from elsewhere. There was definitely no sync of the savedefconfig going on there :)
> CONFIG_QCOM_ICC_BWMON=m
Commit 76f11e77f919 enabled config QCOM_ICC_BWMON, but like config ARCH_BCMBCA, that config does not exist on arm-soc arm/defconfig branch
On next-20220722, no sync is required
> CONFIG_SLIMBUS=m
Config 5bd773242f75 added a kconfig "imply" on config SLIMBUS from config SOUNDWIRE_QCOM, and this happens to mean that we don't explicitly require config SLIMBUS enabled in the defconfig.
> CONFIG_INTERCONNECT=y
Since commit 06f079816d4c, config TEGRA_MC added a kconfig select on config INTERCONNECT, so no need to explicitly enable from the kconfig
> CONFIG_CONFIGFS_FS=y
From commit cd8bc7d4eb66, config PCI_ENDPOINT_CONFIGFS is enabled in the defconfig, and this selects CONFIG_CONFIGFS_FS, so no need to have explicit enabling in the defconfig.
We still have issues on next-22072022: CONFIG_ARM_CPUIDE CONFIG_DEBUG_INFO CONFIG_DEBUG_INFO_REDUCED
The latter two are not an issue on the arm-soc arm/defconfig.
So let me know if any comments or how to proceed.
And would each config item deletion merit a separate patch?
Thanks, John
| |