Messages in this thread | | | Date | Mon, 25 Jul 2022 17:04:47 +0530 | Subject | Re: [PATCH 2/8] dt-bindings: display: ti,am65x-dss: Add IO CTRL property for AM625 OLDI | From | Aradhya Bhatia <> |
| |
On 21-Jul-22 05:02, Rob Herring wrote: > On Tue, Jul 19, 2022 at 01:38:39PM +0530, Aradhya Bhatia wrote: >> Add am625-io-ctrl dt property to provide access to the control MMR >> registers for the OLDI TXes. >> >> These registers are used to control the power input to the OLDI TXes as >> well as to configure them in the Loopback test mode. >> >> The MMR IO controller device has been updated since the AM65x SoC and >> hence a newer property is needed to describe the one in AM625 SoC. >> >> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> >> --- >> .../bindings/display/ti/ti,am65x-dss.yaml | 21 +++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml >> index 11d9b3821409..672765ad1f30 100644 >> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml >> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml >> @@ -118,12 +118,33 @@ properties: >> and OLDI_CLK_IO_CTRL registers. This property is needed for OLDI >> interface to work. >> >> + ti,am625-oldi-io-ctrl: >> + $ref: "/schemas/types.yaml#/definitions/phandle" >> + description: >> + phandle to syscon device node mapping OLDI IO_CTRL registers, for >> + AM625 SoC. The mapped range should point to OLDI0_DAT0_IO_CTRL, >> + and map the registers up till OLDI_LB_CTRL. This property allows >> + the driver to control the power delivery to the OLDI TXes and >> + their loopback control as well. > > What's wrong with the existing ti,am65x-oldi-io-ctrl other than the less > than ideal naming? And you just continued with the same issue so the > next part will need yet another property. Sorry, no. Just use the > existing property. > I introduced the new property because the peripheral was a newer and different implementation from the previous one.
However, the same property can be re-used. I will do so in the re-spin.
>> + >> max-memory-bandwidth: >> $ref: /schemas/types.yaml#/definitions/uint32 >> description: >> Input memory (from main memory to dispc) bandwidth limit in >> bytes per second >> >> +if: >> + properties: >> + compatible: >> + contains: >> + const: ti,am65x-dss >> +then: >> + properties: >> + ti,am625-oldi-io-ctrl: false >> +else: >> + properties: >> + ti,am65x-oldi-io-ctrl: false >> + >> required: >> - compatible >> - reg >> -- >> 2.37.0 >> >>
Regards Aradhya
| |