Messages in this thread | | | Subject | Re: [PATCH] net: macsec: fix potential resource leak in macsec_add_rxsa() and macsec_add_txsa() | From | patchwork-bot+netdevbpf@kernel ... | Date | Mon, 25 Jul 2022 11:00:14 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>:
On Fri, 22 Jul 2022 17:29:02 +0800 you wrote: > init_rx_sa() allocates relevant resource for rx_sa->stats and rx_sa-> > key.tfm with alloc_percpu() and macsec_alloc_tfm(). When some error > occurs after init_rx_sa() is called in macsec_add_rxsa(), the function > released rx_sa with kfree() without releasing rx_sa->stats and rx_sa-> > key.tfm, which will lead to a resource leak. > > We should call macsec_rxsa_put() instead of kfree() to decrease the ref > count of rx_sa and release the relevant resource if the refcount is 0. > The same bug exists in macsec_add_txsa() for tx_sa as well. This patch > fixes the above two bugs. > > [...]
Here is the summary with links: - net: macsec: fix potential resource leak in macsec_add_rxsa() and macsec_add_txsa() https://git.kernel.org/netdev/net/c/c7b205fbbf3c
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |