Messages in this thread | | | Date | Mon, 25 Jul 2022 12:04:07 +0200 | Subject | Re: [PATCH v2 7/8] arm64: dts: mediatek: cherry: Enable keyboard PWM backlight | From | AngeloGioacchino Del Regno <> |
| |
Il 25/07/22 11:57, Chen-Yu Tsai ha scritto: > n Thu, Jul 21, 2022 at 10:53 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Add a pwm-leds node to enable the PWM controlled keyboard backlight. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi >> index ca9955a97f8f..9086a440a995 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi >> @@ -4,6 +4,7 @@ >> */ >> >> #include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/leds/common.h> >> #include "mt8195.dtsi" >> #include "mt6359.dtsi" >> >> @@ -31,6 +32,18 @@ dmic_codec: dmic-codec { >> wakeup-delay-ms = <50>; >> }; >> >> + led-controller { >> + compatible = "pwm-leds"; >> + >> + keyboard_backlight: keyboard-backlight { >> + default-state = "off"; >> + function = LED_FUNCTION_KBD_BACKLIGHT; >> + label = "cros_ec::kbd_backlight"; >> + max-brightness = <1023>; >> + pwms = <&cros_ec_pwm 3>; >> + }; >> + }; >> + > > This didn't work for me. However using "google,cros-kbd-led-backlight" > under the EC did. That might be a better option.
Strange. But okay if there's a better option I'll check that out for v3.
Cheers! Angelo
> > ChenYu > >> memory@40000000 { >> device_type = "memory"; >> reg = <0 0x40000000 0 0x80000000>; >> -- >> 2.35.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |