lkml.org 
[lkml]   [2022]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 09/10] PCI: imx6: Add iMX8MM PCIe EP mode
Hi Richard,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20220718]
[cannot apply to helgaas-pci/next robh/for-next char-misc/char-misc-testing v5.19-rc7 v5.19-rc6 v5.19-rc5 linus/master v5.19-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Richard-Zhu/Add-iMX-PCIe-EP-mode-support/20220719-180421
base: 036ad6daa8f0fd357af7f50f9da58539eaa6f68c
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220724/202207241506.pe2RsQWk-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1ebd36a42f9836f97d60b714e8ae000135c68576
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Richard-Zhu/Add-iMX-PCIe-EP-mode-support/20220719-180421
git checkout 1ebd36a42f9836f97d60b714e8ae000135c68576
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/pci/controller/dwc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/pci/controller/dwc/pci-imx6.c: In function 'imx6_add_pcie_ep':
>> drivers/pci/controller/dwc/pci-imx6.c:1069:32: error: initialization of 'struct pcie_port *' from incompatible pointer type 'struct dw_pcie_rp *' [-Werror=incompatible-pointer-types]
1069 | struct pcie_port *pp = &pci->pp;
| ^
drivers/pci/controller/dwc/pci-imx6.c:1072:29: error: passing argument 1 of 'imx6_pcie_host_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
1072 | imx6_pcie_host_init(pp);
| ^~
| |
| struct pcie_port *
drivers/pci/controller/dwc/pci-imx6.c:925:51: note: expected 'struct dw_pcie_rp *' but argument is of type 'struct pcie_port *'
925 | static int imx6_pcie_host_init(struct dw_pcie_rp *pp)
| ~~~~~~~~~~~~~~~~~~~^~
cc1: some warnings being treated as errors


vim +1069 drivers/pci/controller/dwc/pci-imx6.c

1060
1061 static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
1062 struct platform_device *pdev)
1063 {
1064 int ret;
1065 unsigned int pcie_dbi2_offset;
1066 struct dw_pcie_ep *ep;
1067 struct resource *res;
1068 struct dw_pcie *pci = imx6_pcie->pci;
> 1069 struct pcie_port *pp = &pci->pp;
1070 struct device *dev = pci->dev;
1071
1072 imx6_pcie_host_init(pp);
1073 ep = &pci->ep;
1074 ep->ops = &pcie_ep_ops;
1075
1076 switch (imx6_pcie->drvdata->variant) {
1077 case IMX8MM_EP:
1078 pcie_dbi2_offset = SZ_1M;
1079 break;
1080 default:
1081 pcie_dbi2_offset = SZ_4K;
1082 break;
1083 }
1084 pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
1085 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
1086 if (!res)
1087 return -EINVAL;
1088
1089 ep->phys_base = res->start;
1090 ep->addr_size = resource_size(res);
1091 ep->page_size = SZ_64K;
1092
1093 ret = dw_pcie_ep_init(ep);
1094 if (ret) {
1095 dev_err(dev, "failed to initialize endpoint\n");
1096 return ret;
1097 }
1098 /* Start LTSSM. */
1099 imx6_pcie_ltssm_enable(dev);
1100
1101 return 0;
1102 }
1103

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-07-24 10:04    [W:0.104 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site