lkml.org 
[lkml]   [2022]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: r8188eu: handle errors from ReadAdapterInfo8188EU
On Sun, Jul 24, 2022 at 06:14:05PM +0200, Martin Kaiser wrote:
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -332,7 +332,8 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
> rtl8188eu_interface_configure(padapter);
>
> /* step read efuse/eeprom data and get mac_addr */
> - ReadAdapterInfo8188EU(padapter);
> + if (ReadAdapterInfo8188EU(padapter) < 0)
> + goto handle_dualmac;

You threw away the error returned to you here, why? Shouldn't it
propagate upward?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-07-24 18:19    [W:0.034 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site