Messages in this thread | | | Date | Sat, 23 Jul 2022 12:17:45 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH v0] media: i2c: fix the erroneous pointer initializer |
| |
Hi Lin,
On Fri, Jul 22, 2022 at 11:08:01AM +0800, Lin Ma wrote: > Hello there, > > > > > > There are obvious errors for the initializer of ov02a10_i2c_driver, > > ov2682_i2c_driver, and ov5695_i2c_driver as the code intended to assign > > "address of function pointer" to function pointer. This patch fixes them > > by removing redundant & operators. > > > > Signed-off-by: Lin Ma <linma@zju.edu.cn> > > Sorry as this is a false alarm :( > I just get confused by the function pointers and function addresses and > the original code works fine.
Thanks for the patch.
The original code works fine but functions are always by reference, the preference is without &.
First patch version is typically 1 and there's no need to denote that.
-- Regards,
Sakari Ailus
| |