lkml.org 
[lkml]   [2022]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 3/3] ARM: qcom_defconfig: order items with savedefconfig
Date
On Samstag, 23. Juli 2022 19:36:17 CEST Krzysztof Kozlowski wrote:
> On 23/07/2022 11:58, Luca Weiss wrote:
> > See also
> > https://lore.kernel.org/linux-arm-msm/20191104210943.101393-1-luca@z3ntu.x
> > yz/ (never applied for some reason)
>
> Mentioned patch is incorrect so should not be applied - it removes at
> least TMPFS which is not desired. I did not check other removed symbols.

For this example: TMPFS is still enabled after this, it's selected by other
options, like DRM or COMMON_CLK.

Imo not doing this just hides the brokeness as options wouldn't get selected
anyways when you do "make qcom_defconfig". Savedefconfig afterwards just puts
reality into the defconfig file. And yes, if some option gets lost then some
dependency for it probably needs to get enabled as well and this should get
fixed.

Regards
Luca

>
>
> Best regards,
> Krzysztof




\
 
 \ /
  Last update: 2022-07-23 20:18    [W:0.062 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site