Messages in this thread | | | From | "Chen, Tim C" <> | Subject | RE: [PATCH] mm: Remove the redundant updating of stats_flush_threshold | Date | Fri, 22 Jul 2022 17:57:56 +0000 |
| |
> >On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote: >> From: jiebin sun <jiebin.sun@intel.com> >> >> Remove the redundant updating of stats_flush_threshold. If the global >> var stats_flush_threshold has exceeded the trigger value for >> __mem_cgroup_flush_stats, further increment is unnecessary. >> >> Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads). >> >> Score gain: 1.95x >> Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%) >> >> CPU: ICX 8380 x 2 sockets >> Core number: 40 x 2 physical cores >> Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads) >> >> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com> > >Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev> > >Good optimization, thanks!
Looks good. Nice performance improvement.
Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
| |