lkml.org 
[lkml]   [2022]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm/bridge: ti-sn65dsi86: Use dev_err_probe() to avoid polluting the log
From


On 22.07.2022 09:47, Javier Martinez Canillas wrote:
> If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
> ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
>
> But this path also prints an error message, which pollutes the kernel log
> since is printed on every probe deferral, i.e:
>
> $ dmesg | grep "failed to create panel bridge" | wc -l
> 38
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards
Andrzej

> ---
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 369bf72717f6..90bbabde1595 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1206,10 +1206,9 @@ static int ti_sn_bridge_probe(struct auxiliary_device *adev,
> int ret;
>
> pdata->next_bridge = devm_drm_of_get_bridge(pdata->dev, np, 1, 0);
> - if (IS_ERR(pdata->next_bridge)) {
> - DRM_ERROR("failed to create panel bridge\n");
> - return PTR_ERR(pdata->next_bridge);
> - }
> + if (IS_ERR(pdata->next_bridge))
> + return dev_err_probe(pdata->dev, PTR_ERR(pdata->next_bridge),
> + "failed to create panel bridge\n");
>
> ti_sn_bridge_parse_lanes(pdata, np);
>

\
 
 \ /
  Last update: 2022-07-22 14:57    [W:0.092 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site