lkml.org 
[lkml]   [2022]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/i915: stop using swiotlb
On Fri, Jul 22, 2022 at 10:45:54AM +0100, Tvrtko Ursulin wrote:
>> - unsigned int size = swiotlb_max_segment();
>> -
>> - if (size == 0)
>> - size = UINT_MAX;
>
> On a more detailed look, there was a CI failure which makes me think this
> cap might need to stay. Because max sg segment is unsigned int. So I wonder
> if sg contstruction overflows without it.
>
> If this quick analysis is right, you could leave i915_sg_segment_size
> helper and cap the return from dma_max_mapping_size to UINT_MAX in it.

As dma_max_mapping_size retuns a size_t it would be good to make
all variables using it a size_t as well. In places where that gets
lower to an unsigned int your probably want this cap.

\
 
 \ /
  Last update: 2022-07-22 11:59    [W:1.495 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site