Messages in this thread | | | Date | Fri, 22 Jul 2022 09:01:15 +0100 | From | Ben Dooks <> | Subject | Re: [PATCH] kallsyms: make arch_get_kallsym() static |
| |
On Thu, Jul 21, 2022 at 08:22:39AM -0700, Christoph Hellwig wrote: > On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote: > > The arch_get_kallsym() function is not used anywhere in the kernel > > now, so it should at-least be static or just be removed as there > > are no users. Making it static fixes the following sparse warning: > > > > kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static? > > It fixes the warning, but isn't exactly useful. Please just remove it, > get_ksymbol_arch and iter->pos_arch_end entirely instead.
Ok, probably the best. I didn't have time to do any archeaology on it to find out if it has ever been used.
-- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
| |