lkml.org 
[lkml]   [2022]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irqchip/mmp: fix missing extern init code
On Fri, Jul 22, 2022 at 08:41:53AM +0100, Marc Zyngier wrote:
> On Thu, 21 Jul 2022 22:51:47 +0100,
> Ben Dooks <ben-linux@fluff.org> wrote:
> >
> > The functions icu_init_irq and mmp2_init_icu are exported
> > from this code, so declare them in the header file to avoid
> > the following sparse warnings:

> $ git grep -E "icu_init_irq|mmp2_init_icu"
> arch/arm/mach-mmp/mmp2.c: mmp2_init_icu();
> arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void);
> arch/arm/mach-mmp/pxa168.c: icu_init_irq();
> arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void);
> arch/arm/mach-mmp/pxa910.c: icu_init_irq();
> arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void);
> drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void)
> drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void)
>
> If you are going to fix this, please fix it sensibly.

Ok, didn't realise these where not being built my the v7_multi defconfig.
Should this all go into one patch or do the arch/arm bits need to go via
some arm tree?

--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

\
 
 \ /
  Last update: 2022-07-22 10:04    [W:0.060 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site