Messages in this thread Patch in this message | | | Subject | Re: [PATCH] nbd: add missing definition of pr_fmt | From | Yu Kuai <> | Date | Sat, 23 Jul 2022 10:15:39 +0800 |
| |
Hi!
在 2022/07/20 19:46, Yu Kuai 写道: > Hi ! > > 在 2022/07/18 22:32, Joe Perches 写道: >> On Mon, 2022-07-18 at 21:52 +0800, Yu Kuai wrote: >>> 在 2022/07/06 17:33, Yu Kuai 写道: >>>> From: Yu Kuai <yukuai3@huawei.com> >>>> >>>> commit 1243172d5894 ("nbd: use pr_err to output error message") tries >>>> to define pr_fmt and use short pr_err() to output error message, >>>> however, the definition is missed. >>> friendly ping ... >> [] >>>> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c >> [] >>>> @@ -44,6 +44,9 @@ >>>> #include <linux/nbd-netlink.h> >>>> #include <net/genetlink.h> >>>> +#undef pr_fmt >>>> +#define pr_fmt(fmt) "nbd: " fmt >>>> + >> Typically, this #define is place before all #include lines >> so there is no need for an #undef
I tried to remove the #undef:
--- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -44,7 +44,6 @@ #include <linux/nbd-netlink.h> #include <net/genetlink.h>
#define pr_fmt(fmt) "nbd: " fmt
And then following warning is triggered:
drivers/block/nbd.c:47: warning: "pr_fmt" redefined 47 | #define pr_fmt(fmt) "nbd: " fmt It semms that keeping that #undef is the right thing to do.
Thanks, Kuai > > Thanks for you advice, I'll do that in v2. > > Kuai > > . >
| |