lkml.org 
[lkml]   [2022]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] hfsplus: Fix code typo
From
Date
On Sat, 2022-07-23 at 03:51 +0800, Xin Gao wrote:
> The double `free' is duplicated in line 498, remove one.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> fs/hfsplus/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c
> index 66774f4cb4fd..655cf60eabbf 100644
> --- a/fs/hfsplus/btree.c
> +++ b/fs/hfsplus/btree.c
> @@ -495,7 +495,7 @@ void hfs_bmap_free(struct hfs_bnode *node)
> m = 1 << (~nidx & 7);
> byte = data[off];
> if (!(byte & m)) {
> - pr_crit("trying to free free bnode "
> + pr_crit("trying to free bnode "

What makes you think this message needs correcting? The code seems to
be checking whether we're freeing an already free bnode, meaning the
message looks correct as is and the proposed change makes it incorrect.

James


\
 
 \ /
  Last update: 2022-07-22 22:15    [W:0.038 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site