lkml.org 
[lkml]   [2022]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description
On 2022-07-21 02:06, William Zhang wrote:
> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add
> generic 4908 board entry.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>

Acked-by: Rafał Miłecki <rafal@milecki.pl>

(with one minor comment below)

> ---
>
> Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> index 6a64afa95918..4494a2c58c7f 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
> @@ -36,18 +36,22 @@ properties:
> - tplink,archer-c2300-v1
> - const: brcm,bcm4906
> - const: brcm,bcm4908
> + - const: brcm,bcmbca
>
> - description: BCM4908 based boards
> items:
> - enum:
> - asus,gt-ac5300
> - netgear,raxe500
> + - brcm,bcm94908

I think it would be nice to keep enum entries sorted


> - const: brcm,bcm4908
> + - const: brcm,bcmbca
>
> - description: BCM49408 based boards
> items:
> - const: brcm,bcm49408
> - const: brcm,bcm4908
> + - const: brcm,bcmbca
>
> - description: BCM4912 based boards
> items:

\
 
 \ /
  Last update: 2022-07-21 08:28    [W:0.081 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site