Messages in this thread Patch in this message | | | From | Gene Chen <> | Subject | [PATCH v2 2/6] usb: typec: tcpci_rt1711h: Fix vendor setting when set vconn | Date | Thu, 21 Jul 2022 14:11:40 +0800 |
| |
From: Gene Chen <gene_chen@richtek.com>
replace overwrite whole register with update bits
Signed-off-by: Gene Chen <gene_chen@richtek.com> --- drivers/usb/typec/tcpm/tcpci_rt1711h.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c index b56a0880a044..3309ceace2b2 100644 --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c @@ -23,6 +23,7 @@ #define RT1711H_RTCTRL8_SET(ck300, ship_off, auto_idle, tout) \ (((ck300) << 7) | ((ship_off) << 5) | \ ((auto_idle) << 3) | ((tout) & 0x07)) +#define RT1711H_AUTOIDLEEN_MASK BIT(3) #define RT1711H_RTCTRL11 0x9E @@ -109,8 +110,8 @@ static int rt1711h_set_vconn(struct tcpci *tcpci, struct tcpci_data *tdata, { struct rt1711h_chip *chip = tdata_to_rt1711h(tdata); - return rt1711h_write8(chip, RT1711H_RTCTRL8, - RT1711H_RTCTRL8_SET(0, 1, !enable, 2)); + return regmap_update_bits(chip->data.regmap, RT1711H_RTCTRL8, + RT1711H_AUTOIDLEEN_MASK, enable ? 0 : 0xFF); } static int rt1711h_start_drp_toggling(struct tcpci *tcpci, -- 2.25.1
| |